[PATCH] D93731: scudo: Support memory tagging in the secondary allocator.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In D93731#2537982 <https://reviews.llvm.org/D93731#2537982>, @cferris wrote:

> Unfortunately, 32 bit tests are failing with this abort:
>
> [ RUN      ] ScudoCombinedTest.BasicCombined
> Scudo ERROR: CHECK failed @ external/scudo/standalone/memtag.h:235 ((0 && "memory tagging not supported")) != (0) (0, 0)
> Aborted
>
> It looks like a number of the ScudoCombined tests all fail with this abort, but only on 32 bit. The 64 bit versions pass without any errors.
>
> It looks like the test is trying to do something memtag related that isn't supported on 32 bit. Should the tests be disabled on 32 bit?

Sorry, I forgot to test on 32-bit. The problem with the tests should be fixed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93731/new/

https://reviews.llvm.org/D93731