[PATCH] D95908: [AArch64][GlobalISel] Change store value type from p0 -> s64 to import patterns

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 16:57:47 PST 2021


paquette created this revision.
paquette added a reviewer: aemerson.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls, rovka.
paquette requested review of this revision.
Herald added a project: LLVM.

Similar to the G_PTR_ADD + G_LOAD twiddling we do in `preISelLower`.

The imported patterns expect scalars only, so they can't handle things like

  G_STORE %ptr1, %ptr2

To get around this, use s64 instead.

(This probably makes a good portion of the manual selection code for G_STORE
dead.)

This is a 0.2% geomean code size improvement on CTMark at -Os.

(Best is consumer-typeset @ -0.7%)


https://reviews.llvm.org/D95908

Files:
  llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/select-store.mir
  llvm/test/CodeGen/AArch64/GlobalISel/sext-inreg-ldrow-16b.mir
  llvm/test/CodeGen/AArch64/GlobalISel/store-addressing-modes.mir
  llvm/test/CodeGen/AArch64/GlobalISel/store-wro-addressing-modes.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95908.320953.patch
Type: text/x-patch
Size: 7367 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210203/8a0376f6/attachment.bin>


More information about the llvm-commits mailing list