[PATCH] D93731: scudo: Support memory tagging in the secondary allocator.

Tue Feb 2 16:03:38 PST 2021

cferris requested changes to this revision.
cferris added a comment.
This revision now requires changes to proceed.

Unfortunately, 32 bit tests are failing with this abort:

[ RUN      ] ScudoCombinedTest.BasicCombined
Scudo ERROR: CHECK failed @ external/scudo/standalone/memtag.h:235 ((0 && "memory tagging not supported")) != (0) (0, 0)
Aborted

It looks like a number of the ScudoCombined tests all fail with this abort, but only on 32 bit. The 64 bit versions pass without any errors.

It looks like the test is trying to do something memtag related that isn't supported on 32 bit. Should the tests be disabled on 32 bit?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93731/new/

https://reviews.llvm.org/D93731