[PATCH] D94316: [lld-macho] Associate each Symbol with an InputFile

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: lld/MachO/SymbolTable.h:37
 public:
-  Symbol *addDefined(StringRef name, InputSection *isec, uint32_t value,
-                     bool isWeakDef, bool isPrivateExtern);
+  Symbol *addDefined(StringRef name, InputFile *, InputSection *,
+                     uint32_t value, bool isWeakDef, bool isPrivateExtern);
----------------
int3 wrote:
> smeenai wrote:
> > Pretty sure I've asked you this before (but I can't remember the answer): how come some parameters are named in the declaration and some aren't?
> my personal preference is to only include names if they convey information that's not already in the type name :) so `StringRef name` is useful, but `InputSection *isec` seems redundant
Ah, right ... sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94316/new/

https://reviews.llvm.org/D94316