[PATCH] D95895: [GlobalISel] Check if branches use the same MBB in matchOptBrCondByInvertingCond

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 14:49:21 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:975
+  if (!MBB->isLayoutSuccessor(BrCondTarget) ||
+      BrCondTarget == MI.getOperand(0).getMBB())
     return false;
----------------
I would check this first (also reformat as return X || Y)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95895/new/

https://reviews.llvm.org/D95895



More information about the llvm-commits mailing list