[PATCH] D88715: [llvm-objdump] --source: drop the warning when there is no debug info

Tue Feb 2 13:51:20 PST 2021

MaskRay added a comment.

In D88715#2343710 <https://reviews.llvm.org/D88715#2343710>, @MaskRay wrote:

> In D88715#2343696 <https://reviews.llvm.org/D88715#2343696>, @jhenderson wrote:
>
>> In D88715#2343345 <https://reviews.llvm.org/D88715#2343345>, @MaskRay wrote:
>>
>>> Ping:)
>>
>> Is this ping directed specifically at @mmpozulp? I wasn't sure.
>
> @mmpozulp may be inactive and then it is to you :) I think the warning code should be removed (like this patch does) until it has a less noisy implementation. (It could be argued that such behavior may need to under an option.)

Apologies that I did not see your previous test suggestion. Today I received another internal report that the `failed to parse debug information` warning is confusing when the executable has object file with no debug info (very common if we count system libraries and assembly object files).

As of whether it is useful to only report the warning when the executable has debug info but one object file does not have debug info: I think the proposal is still controversial.

So I'll suggest we restore to the previous state where we don't warn for missing debug info. Note: we don't warn for malformed debug info. That hasn't been properly fixed by D62462 <https://reviews.llvm.org/D62462>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88715/new/

https://reviews.llvm.org/D88715