[PATCH] D95832: [SampleFDO][NFC] Add inline keywords to member functions that will be in the template header file

[Rong Xu via llvm-commits]

On Tue, Feb 2, 2021 at 11:43 AM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added a comment.
>
> Instead of having inlining keyword, it is better to move the out of line
> definitions as inline bodies in the class.
>
Are these two ways the same from a semantic point of view?

Some of the functions are really large. Adding into class really affects
the readability.

>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D95832/new/
>
> https://reviews.llvm.org/D95832
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210202/772f25e2/attachment-0001.html>