[PATCH] D95807: [RFC][Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

[John McCall via Phabricator via llvm-commits]

rjmccall added a comment.

In D95807#2537105 <https://reviews.llvm.org/D95807#2537105>, @lxfind wrote:

> By the way, is everyone comfortable with dropping the test lines using the legacy pass manager for Coroutine? 
> It's really painful to update the tests to keep both legacy pass manager and new pass manager, now that the pass sequence becomes much different. (CoroSplit runs late in CGSCC pipeline for NewPM, but early in legacy pm).
> If we want to keep the legacy PM tests for a while for coroutine, I could wait until everyone is comfortable before updating this patch again.

What's most important is to test the pass.  If you want to port most of the tests to unconditionally test under the new PM, that's fine with me.  We should keep some tests that validate basic full-coroutine-pipeline behavior under the old PM until we actually retire the old PM, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95807/new/

https://reviews.llvm.org/D95807