[PATCH] D95874: [TableGen] Temporary hack to add type checking for multiclass template arguments

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Should probably add a testcase



================
Comment at: llvm/lib/TableGen/TGParser.cpp:3511
     for (unsigned i = 0, e = TArgs.size(); i != e; ++i) {
       if (i < TemplateVals.size()) {
+        // This if block is a hack so we can track down multiclass template
----------------
Invert and reduce indentation?


================
Comment at: llvm/lib/TableGen/TGParser.cpp:3516
+          auto *ArgType = MC->Rec.getValue(TArgs[i])->getType();
+          if (!ArgValue->getCastTo(ArgType))
+            return Error(SubClassLoc,
----------------
Braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95874/new/

https://reviews.llvm.org/D95874