[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 07:02:56 PST 2021


mtrofin added a comment.

In D95849#2535939 <https://reviews.llvm.org/D95849#2535939>, @jhenderson wrote:

> I assume this now runs cleanly. If so, LGTM. Probably worth mentioning on the mailing list thread too, so wrap up that conversation. By the way, did we ever figure out how many of the failures were genuine bugs versus deliberate isntances?

Except for the tests under  llvm/test/Transforms/Attributor/, which D94744 <https://reviews.llvm.org/D94744> explicitly opts into allowing unused prefixes (and which @jdoerfert described as intentionally so), the rest (~1300) were bugs: i.e. unintentionally unused prefixes.

Out of them, a small handful were spelling mistakes (identified as such during code review by their authors) and fixed rather than removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95849/new/

https://reviews.llvm.org/D95849



More information about the llvm-commits mailing list