[PATCH] D88391: [M68k] (Patch 5/8) Target lowering

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kISelLowering.cpp:1453
+  // MUL on values larger than 16 bits cannot be handle by M68000 and M68010
+  if (!Subtarget.atLeastM68020()) {
+    EVT VT = N->getValueType(0);
----------------
Why not set Legal/Custom in setOperationAction ISD::MUL based on Subtarget?


================
Comment at: llvm/lib/Target/M68k/M68kISelLowering.cpp:1473
+      SDValue Args[] = {HiLHS, LHS, HiRHS, RHS};
+      SDValue Ret = makeLibCall(DAG, RTLIB::MUL_I64, VT, Args, LCO, DL).first;
+
----------------
 Is this i64 lowering active? The action is set to libcall.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88391/new/

https://reviews.llvm.org/D88391