[PATCH] D95859: [asan] Avoid putting globals in a comdat section.

[pierre gousseau via Phabricator via llvm-commits]

pgousseau created this revision.
pgousseau added reviewers: kcc, eugenis, vitalybuka, filcab, probinson.
Herald added a subscriber: hiraditya.
pgousseau requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Putting globals in a comdat for dead-stripping changes the semantic and can potentially cause false negative odr violations at link time.
If odr indicators are used, we keep the comdat sections, as link time odr violations will be dectected for the odr indicator symbols.

This fixes PR 47925


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95859

Files:
  llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
  llvm/test/Instrumentation/AddressSanitizer/global_metadata.ll
  llvm/test/Instrumentation/AddressSanitizer/global_with_comdat.ll
  llvm/test/Instrumentation/AddressSanitizer/instrument-section-invalid-c-ident.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95859.320723.patch
Type: text/x-patch
Size: 9190 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210202/869685c0/attachment.bin>