[PATCH] D95807: [RFC][Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 01:27:42 PST 2021


ChuanqiXu added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:1032
-  // pass to FPM below because it will also verify all the global data.
-  if (verifyFunction(F, &errs()))
-    report_fatal_error("Broken function");
----------------
rjmccall wrote:
> ChuanqiXu wrote:
> > Is it necessary to remain the verify process?
> It's probably okay for it to go away now.
I prefer to remain the verification *personally* since it had reported many errors for me :).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95807/new/

https://reviews.llvm.org/D95807



More information about the llvm-commits mailing list