[PATCH] D95817: NFC: Migrate LoopUnrollPass to work on InstructionCost
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 2 01:23:59 PST 2021
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp:650
+ return {{unsigned(*UnrolledCost.getValue()),
+ unsigned(*RolledDynamicCost.getValue())}};
}
----------------
should we add an accessor that returns the value directly? The extra dereferences look odd, especially because we already check that the cost is valid.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95817/new/
https://reviews.llvm.org/D95817
More information about the llvm-commits
mailing list