[PATCH] D95833: [RISCV] Replace NoX0 SDNodeXForm with a ComplexPattern to do the selection of the VL operand.
Roger Ferrer Ibanez via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 1 23:23:02 PST 2021
rogfer01 accepted this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.
I admit that I initially wasn't convinced by the idea of `ComplexPattern` including both the matching logic (which is only `return true`) and a bit of selection logic (`selectImm`) in the input DAG. But on a second thought this allows the two logics be kept together.
Also if this is the common way to do this then we better use existing idioms. To be fair that `undef` in the `SDNodeXForm` has always looked a bit off to me.
Thanks for the cleanup @craig.topper
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95833/new/
https://reviews.llvm.org/D95833
More information about the llvm-commits
mailing list