[PATCH] D95690: [LoopVectorize] improve IR fast-math-flags propagation in reductions

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/lib/Analysis/IVDescriptors.cpp:312
+          //       standardize on fmin/fmax via intrinsics, this can be removed.
+          assert(isa<FCmpInst>(Sel->getCondition()) && "Expected fcmp min/max");
+          CurFMF |= cast<FCmpInst>(Sel->getCondition())->getFastMathFlags();
----------------
MaskRay wrote:
> I notice that the assert may fail. We will work on a reproduce.
Ok, thanks. I have missed some way that this loop works then, but it should be fine to use dyn_cast here to guard against that possibility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95690/new/

https://reviews.llvm.org/D95690