[PATCH] D88391: [M68k] (Patch 5/8) Target lowering

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kISelLowering.cpp:1490
+    }
+  }
+
----------------
myhsu wrote:
> RKSimon wrote:
> > iirc we support this generically through a TLI callback. 
> I assume you're talking about the lines above regarding converting mul to shift. If that's the case, are you suggesting. to put those into DAG combiner callbacks?
Yes, you should be able to override TargetLowering::decomposeMulByConstant to let DAGCombine do this for you. See X86TargetLowering::decomposeMulByConstant for an example.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88391/new/

https://reviews.llvm.org/D88391