[PATCH] D94882: [MC] Upgrade DWARF version to 5 upon .file 0

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 14:37:50 PST 2021


MaskRay added a comment.

In D94882#2528950 <https://reviews.llvm.org/D94882#2528950>, @dblaikie wrote:

> In D94882#2527402 <https://reviews.llvm.org/D94882#2527402>, @jhenderson wrote:
>
>> 
>
> ...
> I wouldn't stand in the way of someone adding a warning - with all the requisite support for plumbing through the needed flags (to support the necessary differentiation between implicit and explicit version and the ability to enable/disable it), but I wouldn't hold up this patch on that/suggest that that work needs to be done in conjunction with this.

(That is also my current feeling. The additional plumbing & the perceived low value made me think I will add the diagnostic)
Ping @jhenderson 😊


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94882/new/

https://reviews.llvm.org/D94882



More information about the llvm-commits mailing list