[PATCH] D88392: [M68k] (Patch 6/8) IR Tests

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 13:42:28 PST 2021


myhsu added inline comments.


================
Comment at: llvm/test/CodeGen/M68k/ASM/Arith/imul.ll:1
+; RUN: llc < %s -O0 -mtriple=m68k-linux | FileCheck %s --check-prefix=x00
+
----------------
RKSimon wrote:
> why are you setting -O0 here? 
I don't know the original intention. But after removing it, the last two functions failed their checks. Turns out there is a bug in SelectionDAGISel (which was not triggered in -O0 because the latter uses FastISel) that failed to lower certain cases into using `neg` over `sub`. Which, IIRC, the former is cheaper. 

I decided to split those two functions into a separated files and mark XFAIL.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88392/new/

https://reviews.llvm.org/D88392



More information about the llvm-commits mailing list