[PATCH] D95811: AMDGPU/LLD: Add target id and code object v4 support to linker

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: lld/ELF/Arch/AMDGPU.cpp:109
+uint32_t AMDGPU::calcEFlags() const {
+  assert(!objectFiles.empty());
+
----------------
MaskRay wrote:
> D71101: objectFiles can be empty
But thats only if emulation is supported? And amdgpu emulation is not supported. Otherwise, how will lld determine its an amdgpu arch with objectFiles being empty?

I can change it to
```
if (objectFiles.empty())
  return 0;
```

But I wont be able to add a test without adding emulation support for amdgpu.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95811/new/

https://reviews.llvm.org/D95811