[PATCH] D95811: AMDGPU/LLD: Add target id and code object v4 support to linker

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Arch/AMDGPU.cpp:78
+
+    if ((retXnack == EF_AMDGPU_FEATURE_XNACK_UNSUPPORTED_V4) ||
+        (retXnack != EF_AMDGPU_FEATURE_XNACK_ANY_V4 &&
----------------
`(retXnack == EF_AMDGPU_FEATURE_XNACK_UNSUPPORTED_V4)` =>
`retXnack == EF_AMDGPU_FEATURE_XNACK_UNSUPPORTED_V4`

ditto for tothers


================
Comment at: lld/ELF/Arch/AMDGPU.cpp:109
+uint32_t AMDGPU::calcEFlags() const {
+  assert(!objectFiles.empty());
+
----------------
D71101: objectFiles can be empty


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95811/new/

https://reviews.llvm.org/D95811