[PATCH] D95806: [LoopUnrollAndJam] Check if the loops have an Exit Block

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/test/Transforms/LoopUnrollAndJam/no_exit_block.ll:1
+; RUN: opt -debug-only=loop-unroll-and-jam -passes="default<O3>" -disable-output -enable-unroll-and-jam -allow-unroll-and-jam -unroll-and-jam-count=8 %s 2>&1 | FileCheck %s
+
----------------
This test will need REQUIRES: asserts, otherwise it will fail on release (or at least no-assert) builds.


================
Comment at: llvm/test/Transforms/LoopUnrollAndJam/no_exit_block.ll:16
+
+define dso_local i16 @g() #0 {
+bb:
----------------
You can likely remove the dso_local and maybe the # attributes.

Also maybe this function isn't needed? It could just be a declaration. And it may be possible to simplify h if the problem is an inner infinite loop.


================
Comment at: llvm/test/Transforms/LoopUnrollAndJam/no_exit_block.ll:118
+
+define dso_local void @main() #3 {
+bb:
----------------
This can likely be removed too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95806/new/

https://reviews.llvm.org/D95806