[PATCH] D95490: Support: Extract fs::resize_file_before_mapping_readwrite from FileOutputBuffer

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 11:38:12 PST 2021


rnk added a comment.

If I understand correctly, uploading a new patch triggered new build and test results, and now the reported size is 4096:
https://reviews.llvm.org/harbormaster/unit/view/310832/

So I think everything is working, it's just that mapping the file region on Windows seems to have a side effect of rounding the file size up to a multiple of the page size. So, the solution might be to change 123 to 4096 and hope for the best.

Code looks good to me, though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95490/new/

https://reviews.llvm.org/D95490



More information about the llvm-commits mailing list