[PATCH] D95232: Symbolizer - Teach symbolizer to work directly on object file.

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

This LGTM now, but I would give @ychen and @MaskRay time to take a look.

I'm also curious where the `TODO` discussed at https://reviews.llvm.org/D63521?id=206255#inline-568633 went, and if it was intentional?



================
Comment at: llvm/lib/DebugInfo/Symbolize/Symbolize.cpp:614
+  std::unique_ptr<DIContext> Context = DWARFContext::create(Obj);
+  return createModuleInfo(&Obj, std::move(Context), ObjName);
+}
----------------
Could you add a `FIXME:` comment here to the effect of "Should this handle COFF specially like getOrCreateModuleInfo(const std::string &) does?"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95232/new/

https://reviews.llvm.org/D95232