[PATCH] D95698: [SampleFDO][NFC] Move the core implementation of Sample Profile Loader to a template

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 10:35:21 PST 2021


wenlei added a subscriber: hoy.
wenlei added a comment.

In D95698#2534223 <https://reviews.llvm.org/D95698#2534223>, @davidxl wrote:

> The diff is quite large and it is better to be broken down into smaller pieces in stages.
>
> Stage 1: make selected member functions of the loader as inline functions inside the class (not introducing the new file)
> Stage 2: move sampleloader class into a header file without introducing the template parameter
> stage 3: templatizing the sampleLoader class 
> stage 4: possible other things.



> This will make downstream integration/merging and the review process easier.

+1, thanks for being considerate about downstream. cc: @hoy


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95698/new/

https://reviews.llvm.org/D95698



More information about the llvm-commits mailing list