[PATCH] D95698: [SampleFDO][NFC] Move the core implementation of Sample Profile Loader to a template

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 10:23:01 PST 2021


davidxl added a comment.

The diff is quite large and it is better to be broken down into smaller pieces in stages.

Stage 1: make selected member functions of the loader as inline functions inside the class (not introducing the new file)
Stage 2: move sampleloader class into a header file without introducing the template parameter
stage 3: templatizing the sampleLoader class 
stage 4: possible other things.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95698/new/

https://reviews.llvm.org/D95698



More information about the llvm-commits mailing list