[PATCH] D94938: [lld-macho][NFC] Add some new version options, plus a new option group for versions

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 09:17:07 PST 2021


int3 added inline comments.


================
Comment at: lld/MachO/Options.td:235
+
+def grp_version : OptionGroup<"version">, HelpText<"VERSION CONTROL">;
+
----------------
int3 wrote:
> "version control" makes me think of, well, git and hg... how about "target version"?
seems like you missed this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94938/new/

https://reviews.llvm.org/D94938



More information about the llvm-commits mailing list