[PATCH] D95580: [mlir][spirv] Add support for OpImageType

[Weiwei via Phabricator via llvm-commits]

Weiwei-2021 marked an inline comment as done.
Weiwei-2021 added inline comments.


================
Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp:1023
+  auto dim = spirv::symbolizeDim(operands[2]);
+  if (!dim)
+    return emitError(unknownLoc, "missing Dim for OpTypeImage") << operands[2];
----------------
antiagainst wrote:
> It isn't missing. It's "unknown Dim for OpTypeImage: "
> 
> Similarly for others. :)
Good catch! Thank you. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95580/new/

https://reviews.llvm.org/D95580