[PATCH] D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause

Yashaswini Hegde via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 07:07:41 PST 2021


yhegde updated this revision to Diff 320456.
yhegde added a comment.

This patch has the following changes.

1. The functions CheckIntentInPointer and CheckDefinableObjects are combined and renamed as 'CheckIntentInPointerAndDefinable'.
2. Removed CheckDependArraySection function.
3. cleaned up unwanted code around multimap which was required earlier to reuse some part of the code.
4. Added few test cases in omp-reduction02.f90 and omp-reduction07.f90 to address the review comments.
5. Removed some unnecessary code in CheckIsVarPartOfAnotherVar


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90697/new/

https://reviews.llvm.org/D90697

Files:
  flang/lib/Semantics/check-directive-structure.h
  flang/lib/Semantics/check-omp-structure.cpp
  flang/lib/Semantics/check-omp-structure.h
  flang/lib/Semantics/resolve-directives.cpp
  flang/test/Semantics/omp-reduction01.f90
  flang/test/Semantics/omp-reduction02.f90
  flang/test/Semantics/omp-reduction03.f90
  flang/test/Semantics/omp-reduction04.f90
  flang/test/Semantics/omp-reduction05.f90
  flang/test/Semantics/omp-reduction06.f90
  flang/test/Semantics/omp-reduction07.f90
  flang/test/Semantics/omp-reduction08.f90
  flang/test/Semantics/omp-reduction09.f90
  flang/test/Semantics/omp-reduction10.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90697.320456.patch
Type: text/x-patch
Size: 28824 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210201/a38370e8/attachment.bin>


More information about the llvm-commits mailing list