[PATCH] D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 02:39:16 PST 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

I haven't verified the correctness of this versus GNU objcopy, but assuming the two behave identically after this patch, this is fine by me. I'd like someone else to commit though, as I have too much else on my plate currently.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:214
+    Flags:        [ SHF_ALLOC, SHF_EXECINSTR ]
+    Address:      0x10000
+    AddressAlign: 0x1000
----------------
This could be as small as 0x4000 maybe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95569/new/

https://reviews.llvm.org/D95569



More information about the llvm-commits mailing list