[PATCH] D95730: [MC] Support SHF_GNU_RETAIN as section flag 'R'

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

The change looks fine to me, though I have some slightly nebulous concern that this could be a pain for any downstream toolchain which uses a different thing for that flag value (I have no knowledge of a specific one that does FWIW).

I don't think using a flag to auto-set an OS/ABI value is the right approach. That should come from other assembly directives or command-line options or similar in my opinion. Possibly if any such exist we should reject the flag if they don't set a compatible OS/ABI value?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95730/new/

https://reviews.llvm.org/D95730