[PATCH] D95728: [yaml2obj/obj2yaml/llvm-readobj] Support SHF_GNU_RETAIN

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/section-flags-os-proc.test:104
   Type:  ET_REL
+  OSABI: ELFOSABI_GNU
 Sections:
----------------
Since we don't inspect the OSABI value, I'd just omit this for now. If in the future we choose to do so, we should use a macro to generate this output with and without this OSABI value, so that we can show it being recognised/not recognised as appropriate.

On the other hand, should we inspect the value from the beginning?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/section-flags-os-proc.test:137
+    Type:  SHT_PROGBITS
+    ShFlags: 0x200800
 ## SHF_MASKPROC has a value of 0xf0000000, SHF_EXCLUDE has a value of
----------------
Why the 0x800 flag?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95728/new/

https://reviews.llvm.org/D95728