[PATCH] D94631: [DebugInfo] Add support for multiple value references in debug values, and enable salvaging

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Here are some numbers from end-to-end testing with a Release clang binary.

Starting with a baseline of rG30b8f55378cc <https://reviews.llvm.org/rG30b8f55378cc57f7589694ca9bc4212ce7c2f4ec>:

  % for I in $(seq 10); do time ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null ; done
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  189.68s user 0.71s system 99% cpu 3:10.53 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  190.62s user 0.68s system 99% cpu 3:11.37 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  188.33s user 0.72s system 99% cpu 3:09.10 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  190.87s user 0.73s system 99% cpu 3:11.74 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  200.22s user 0.83s system 99% cpu 3:21.21 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  183.18s user 0.69s system 99% cpu 3:03.89 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  183.99s user 0.64s system 99% cpu 3:04.65 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  184.07s user 0.68s system 99% cpu 3:04.77 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  184.06s user 0.70s system 99% cpu 3:04.78 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  182.41s user 0.67s system 99% cpu 3:03.09 total

With D94631 <https://reviews.llvm.org/D94631> applied on rG30b8f55378cc <https://reviews.llvm.org/rG30b8f55378cc57f7589694ca9bc4212ce7c2f4ec>:

  % for I in $(seq 10); do time ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null ; done
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  190.92s user 0.89s system 99% cpu 3:12.37 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  193.07s user 0.93s system 99% cpu 3:14.22 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  188.49s user 0.76s system 99% cpu 3:09.41 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  193.46s user 0.99s system 99% cpu 3:14.54 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  188.78s user 0.78s system 99% cpu 3:09.59 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  189.35s user 0.80s system 99% cpu 3:10.20 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  190.92s user 0.84s system 99% cpu 3:12.02 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  181.41s user 0.65s system 99% cpu 3:02.07 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  183.23s user 0.68s system 99% cpu 3:04.02 total
  ./bin/clang -w -O3 glyphbench-O0-with-disable-optnone.bc -o /dev/null  180.78s user 0.68s system 99% cpu 3:01.47 total


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94631/new/

https://reviews.llvm.org/D94631