[PATCH] D94426: [VPlan] Introduce VPExternalDef specialization for VPValue

[Satish K Guggilla via Phabricator via llvm-commits]

sguggill added a comment.

In D94426#2518215 <https://reviews.llvm.org/D94426#2518215>, @fhahn wrote:

> Satish, did you see the recent changes to VPValue, which allows for easy distinction if the value is a live-in or defined in a plan? D92281 <https://reviews.llvm.org/D92281> added a `VPValue::getLiveInIRValue` member to access live-in IR values and `VPValue::getDef()` can be used to check if the value is defined inside a plan. It returns `nullptr` for live-ins. Given that, I am not sure if the extra class provides enough benefits to justify the additional complexity?

Hi Florian, I will try to refactor these patches using the recent VPValue changes. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94426/new/

https://reviews.llvm.org/D94426