[PATCH] D95748: AMDGPU: Fix dbg_value handling when forming soft clause bundles

[Daniil Fukalov via Phabricator via llvm-commits]

dfukalov added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:388
       RPT.reset(*B, &LiveRegsCopy);
+      DbgInstrs.clear();
+
----------------
Why don't just create DbgInstrs here?


================
Comment at: llvm/test/CodeGen/AMDGPU/soft-clause-dbg-value.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx906 -mattr=+xnack -run-pass=si-form-memory-clauses -verify-machineinstrs -o - %s | FileCheck %s
+
----------------
Am I right that we need `phi-node-elimination,` before to remove `IsSSA` property to avoid verifier' fail?
Or, dummy copy of first instruction `%0:sreg_64 = COPY $sgpr4_sgpr5 ; defeat IsSSA detection` can be added.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95748/new/

https://reviews.llvm.org/D95748