[PATCH] D95755: [ELF] Support a few elf32lriscv_* & elf64lriscv_* emulations

[Luís Marques via Phabricator via llvm-commits]

luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

Overall seems fine to me.
I don't know if it's worth it more thoroughly testing the various suffix combinations?



================
Comment at: lld/test/ELF/emulation-riscv.s:23-24
 # RV32-NEXT:     FileVersion: 1
-# RV32-NEXT:     OS/ABI: SystemV (0x0)
+# SYSV32-NEXT:   OS/ABI: SystemV (0x0)
+# FBSD32-NEXT:   OS/ABI: FreeBSD (0x9)
 # RV32-NEXT:     ABIVersion: 0
----------------
Unless the -NEXT suffix interacts across prefixes (?!), aren't the -NEXT suffixes here unneeded and misleading?


================
Comment at: lld/test/ELF/emulation-riscv.s:64-65
 # RV64-NEXT:     FileVersion: 1
-# RV64-NEXT:     OS/ABI: SystemV (0x0)
+# SYSV64-NEXT:   OS/ABI: SystemV (0x0)
+# FBSD64-NEXT:   OS/ABI: FreeBSD (0x9)
 # RV64-NEXT:     ABIVersion: 0
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95755/new/

https://reviews.llvm.org/D95755