[PATCH] D95309: [TableGen] Fix anonymous record self-reference in foreach and multiclass
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 31 13:05:23 PST 2021
dblaikie added a comment.
In D95309#2532949 <https://reviews.llvm.org/D95309#2532949>, @dblaikie wrote:
> In D95309#2532913 <https://reviews.llvm.org/D95309#2532913>, @Paul-C-Anagnostopoulos wrote:
>
>> I will push this revision on Tuesday.
>
> Ideally, if you include the "Differential Revision: " line in the commit, PHabricator will automatically detect the commit closes the revision, and update the revision to mention the closing commit, change the status, etc. (don't feel like you have to post a manual "I closed this" comment or anything, if the automatic thing has done the work - unless there's something you'd like to add)
>
> If that doesn't happen for any reason ( such as in this case) please include the hash of the closing commit in a message and set the status of the revision to "closed".
Oh, sorry - I misread. I thought it said that it had been puished on Tuesday. - ignore all that. i'm sure it'll work out fine :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95309/new/
https://reviews.llvm.org/D95309
More information about the llvm-commits
mailing list