[PATCH] D95750: [CMake] [MinGW] Enable use of LLVM_USE_SANITIZER in a MinGW environment
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 31 12:53:35 PST 2021
mstorsjo added a reviewer: rnk.
mstorsjo added a subscriber: rnk.
mstorsjo added a comment.
I guess this looks sensible to me, although I'm a bit unsure why we need to hardcode exactly which sets of sanitizers each target environment supports at the moment. I would kinda understand if we want to keep MSVC separate if those cases used different command line options, but it looks like they don't, so technically one could kinda merge all of the existing unix/msvc cases too. If one would try to use a sanitizer that isn't supported, the cmake configuration wouldn't error out immediately, but it'd be noticed directly when the compiler errors out on the unsupported options anyway.
What does @rnk think about it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95750/new/
https://reviews.llvm.org/D95750
More information about the llvm-commits
mailing list