[PATCH] D95730: [MC] Support SHF_GNU_RETAIN as section flag 'R'

Sat Jan 30 15:27:59 PST 2021

MaskRay added a comment.

Thanks for your insight!

I agree with the comment https://sourceware.org/bugzilla/show_bug.cgi?id=12913#c9

> It may have been an unfortunate choice to use EI_OSABI for the meaning that ELFOSABI_GNU has.  But it's already been done and it's too late now.

Is there any feature triggering ELFOSABI_ARM / ELFOSABI_ARM_AEABI? If there is and such an object file also uses STT_GNU_IFUNC, the single value EI_OSABI is indeed insufficient.

I can see arguments for using ELFOSABI_GNU if EI_OSABI is otherwise 0. It will require some refactoring in MC code and I don't want to hold off the patch on that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95730/new/

https://reviews.llvm.org/D95730