[PATCH] D93764: [LoopUnswitch] Implement first version of partial unswitching.

Sat Jan 30 08:02:49 PST 2021

mstorsjo added a comment.

In D93764#2532219 <https://reviews.llvm.org/D93764#2532219>, @fhahn wrote:

> In D93764#2531332 <https://reviews.llvm.org/D93764#2531332>, @fhahn wrote:
>
>> In D93764#2527703 <https://reviews.llvm.org/D93764#2527703>, @uabelho wrote:
>>
>>> Hi!
>>>
>>> I started seeing crashes with this patch:
>>>
>>> opt -o /dev/null bbi-52312.ll -loop-unswitch
>>>
>>> Result:
>>>
>>> opt: ../lib/Analysis/MemorySSAUpdater.cpp:1154: void llvm::MemorySSAUpdater::applyInsertUpdates(ArrayRef<llvm::CFGUpdate>, llvm::DominatorTree &, const GraphDiff<llvm::BasicBlock *> *): Assertion `IDom && "Block must have a valid IDom."' failed.
>>>
>>> F15216359: bbi-52312.ll <https://reviews.llvm.org/F15216359>
>>
>> Thanks ,let me take a look!
>
> Should be fixed by 10c57268c074 <https://reviews.llvm.org/rG10c57268c074c3ad48f76da38fa2ba575ee3d1f9>. Please let me know if you are seeing any other issues.

I guess that one needs to be backported to 12.x, after cooking in main for a while.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93764/new/

https://reviews.llvm.org/D93764