[PATCH] D95136: [X86] Fix tile config register spill issue.

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 21:12:10 PST 2021


pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:229
+
+struct ReloadTileConfig {
+  enum SuccStatus { NoAMXAtAll = 0, HasAfterCallAMX, HasBeforeCallAMX };
----------------
xiangzhangllvm wrote:
> pengfei wrote:
> > xiangzhangllvm wrote:
> > > LGTM for the logic.
> > Thanks for the review.
> Not try to replace this patch, I update the O(N) algorithm in https://reviews.llvm.org/D95508 just for interest.
> In Non-loop case, it cost O(N), in loop case, it cost O(2N)
So it is related on the number of loops? But in the worst case, a graph may have O(N!) loops? The worst complexity is terrible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95136/new/

https://reviews.llvm.org/D95136



More information about the llvm-commits mailing list