[PATCH] D95591: [yaml2obj/obj2yaml] - Implement program header table as a special Chunk.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 16:09:42 PST 2021


MaskRay added a subscriber: labath.
MaskRay added a comment.

If the idea is that we will have ability to create two program header tables, this seems fine. Such an ability has no use though because only the one referenced by `e_phoff` matters.
So I am still on the fence whether there is a good syntax.

+ @labath who added some `ProgramHeaders:` yaml2obj tests to `lldb/test/Shell`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95591/new/

https://reviews.llvm.org/D95591



More information about the llvm-commits mailing list