[PATCH] D95351: NFC: Migrate SimplifyCFG to work on InstructionCost
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 29 13:04:42 PST 2021
sdesmalen added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:352-361
/// that do not dominate BB have a combined cost lower than CostRemaining and
/// are non-trapping. If both are true, the instruction is inserted into the
/// set and true is returned.
///
/// The cost for most non-trapping instructions is defined as 1 except for
/// Select whose cost is 2.
///
----------------
spatel wrote:
> This code comment should be updated to reflect the new arguments/names.
Good spot, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95351/new/
https://reviews.llvm.org/D95351
More information about the llvm-commits
mailing list