[PATCH] D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC

[Cassie Jones via Phabricator via llvm-commits]

porglezomp updated this revision to Diff 320166.
porglezomp added a comment.

Add a default case assertion, mark vectors as unsupported, cleanups

Existing code seemed to not support vectors correctly. I removed vector support
and re-ran the test suite on AArch64, AMDGPU, and X86, and nothing tested the
behavior of narrowScalar on a vector add, so I think the correct course of
action is to remove support here and add it back again once someone is using
it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95426/new/

https://reviews.llvm.org/D95426

Files:
  llvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h
  llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95426.320166.patch
Type: text/x-patch
Size: 6101 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210129/d1a9c57b/attachment.bin>