[PATCH] D95682: [X86] Fix disassembly of x86-64 GDTLS code sequence

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 09:52:49 PST 2021


MaskRay added a comment.

LG



================
Comment at: llvm/test/MC/Disassembler/X86/x86-64.txt:332
 
-# CHECK: callw 32767
-0x66 0x66 0x48 0xe8 0xff 0x7f
+# CHECK: callq 32767
+0x66 0x66 0x48 0xe8 0xff 0x7f 0x00 0x00
----------------
Add a TODO comment that this should display data16 prefixes.


================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-gdtls.s:1
+# RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux | llvm-objdump -d - | FileCheck %s
+
----------------
`llvm-mc %s -filetype=obj -triple=x86_64`

This is not tied to Linux.


================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-gdtls.s:3
+
+# CHECK:      <foo>:
+# CHECK-NEXT: 0: 66 48 8d 3d 00 00 00 00       leaq    (%rip), %rdi  # 8 <foo+0x8>
----------------
Add a TODO comment that this should display `data16` prefixes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95682/new/

https://reviews.llvm.org/D95682



More information about the llvm-commits mailing list