[PATCH] D88390: [M68k] (Patch 4/8) MC layer and object file support

Fri Jan 29 09:35:39 PST 2021

jrtc27 added a comment.

In D88390#2529089 <https://reviews.llvm.org/D88390#2529089>, @myhsu wrote:

> In D88390#2528951 <https://reviews.llvm.org/D88390#2528951>, @jrtc27 wrote:
>
>> So, uh, correct me if I'm wrong but none of these patches add assembler or disassembler support? Should that not be present before a target is accepted? Otherwise there's no way to test any of the MC layer without including CodeGen.
>
> We don't have AsmParser and disassembler right now. We're using MIR as input to test our integrated assembler, so you're right, we can't test MC layer without CodeGen. But why would that will be a hard blocker?

Ok, MIR is fine and makes sense, if rather clunky compared to assembly. Are those tests cleanly separated from actual CodeGen tests and labeled as such (so once there is an AsmParser and associated tests they can be removed)?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88390/new/

https://reviews.llvm.org/D88390