[PATCH] D95399: [flang][fir] Upstream FIR dialect changes.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 09:14:03 PST 2021


mehdi_amini added a comment.

In D95399#2530820 <https://reviews.llvm.org/D95399#2530820>, @schweitz wrote:

> As explained previously, the original 4 //reviews// (now 5) were subparts of the same comprehensive change set. That comprehensive patch is a coherent, logical set of changes to upstream the code generation pass that converts FIR to LLVM IR.

I see it differently here, I see a lot of independent changes that should be reviewed, restructured to be tested appropriately, and upstreamed independently in a sequence.
Each individual pass could be a single patch with its own test for example.

There is no other way to have a review of these changes right now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95399/new/

https://reviews.llvm.org/D95399



More information about the llvm-commits mailing list