[PATCH] D95350: [SVE][LoopVectorize] Add masked load/store and gather/scatter support for SVE

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 09:09:00 PST 2021


david-arm marked an inline comment as done.
david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h:221
+  bool isLegalMaskedGatherScatter(Type *DataType) const {
+    if (isa<FixedVectorType>(DataType) || !ST->hasSVE())
+      return false;
----------------
kmclaughlin wrote:
> nit: I think this is the same check as we have at the top of `isLegalMaskedLoadStore` - could one of them maybe be changed so that they are consistent?
That's a cracking bug you found @kmclaughlin! It turns out we weren't properly supporting masked loads and stores in the vectoriser either. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95350/new/

https://reviews.llvm.org/D95350



More information about the llvm-commits mailing list