[PATCH] D83069: [LIT] error if directly named test won't be run indirectly

[ben via Phabricator via llvm-commits]

bd1976llvm added a comment.

In D83069#2496184 <https://reviews.llvm.org/D83069#2496184>, @thopre wrote:

> Hi @bd1976llvm
>
> I've just realized in many projects I'm involved in testsuites are managed by cmake and lit is only ever invoked on single testcase. Without passing --no-indirectly-run-check tests fail but when using an old lit I get an error if using this option. Can we allow to turn off the feature via environment variable or configuration?
>
> Thanks in advance.

Hi @thopre,

Sorry - I missed this after the Christmas break somehow. Reading https://reviews.llvm.org/D94766 it seems that you have decided that a config option would be better than a command line option to control this check? +1 to the config option. However, I think that we might still need --no-indirectly-run-check. My scenario would be to allow someone to add and run experimental tests within a teststuite that has the config option set without having to rename them or adjust the testsuite rules. I'm assuming that it is easier to add a command line option than to try to find and disable the relevant config option. Not sure if this is plausible as a scenario but I wanted to raise it. Having raised that scenario, maybe it's still better to add a config option and remove the command line option and then wait to see if there are any usability reports raised?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83069/new/

https://reviews.llvm.org/D83069