[PATCH] D95350: [SVE][LoopVectorize] Add gather/scatter support for SVE

Kerry McLaughlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 05:52:40 PST 2021


kmclaughlin accepted this revision.
kmclaughlin added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h:221
+  bool isLegalMaskedGatherScatter(Type *DataType) const {
+    if (isa<FixedVectorType>(DataType) || !ST->hasSVE())
+      return false;
----------------
nit: I think this is the same check as we have at the top of `isLegalMaskedLoadStore` - could one of them maybe be changed so that they are consistent?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95350/new/

https://reviews.llvm.org/D95350



More information about the llvm-commits mailing list